Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove utils crate and move utils into spark-expr crate #658

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jul 12, 2024

Which issue does this PR close?

N/A

Rationale for this change

This is a follow on to #654 related to the comments in #654 (comment).

I think it was premature for me to create the datafusion-comet-utils crate, so I have moved the utilities into the datafusion-comet-spark-expr crate and removed the datafusion-comet-utils crate.

What changes are included in this PR?

  • Move utilities from utils crate to spark-expr crate
  • Remove utils crate

How are these changes tested?

@andygrove andygrove merged commit c434872 into apache:main Jul 12, 2024
76 checks passed
@andygrove andygrove deleted the remove-utils-crate branch July 12, 2024 22:13
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants